Rating: Keyboard Navigation#3399
Merged
Merged
Conversation
mudbot
Bot
added
enhancement
Codecov Report
@@ Coverage Diff @@
## dev #3399 +/- ##
==========================================
+ Coverage 89.77% 89.89% +0.12%
==========================================
Files 312 312
Lines 9503 9648 +145
==========================================
+ Hits 8531 8673 +142
- Misses 972 975 +3
Continue to review full report at Codecov.
|
henon
reviewed
Nov 19, 2021
|
|
||
|
|
||
| <span @attributes="UserAttributes" class="@ClassName" style="@Style" > | ||
| <span @attributes="UserAttributes" tabindex="@(Disabled?-1:0)" @onkeydown="HandleKeyDown" class="@ClassName" style="@Style" > |
Contributor
There was a problem hiding this comment.
I think you need to add this before user attributes. otherwise they can not override the tabindex
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rating now has keyboard navigation.
Details:
Keyboard navigation
Focused style like the checkbox (only tab focus has style, mouse click focus not)
Docs
Test
How Has This Been Tested?
20211119_135745.mp4
Checklist:
✔️ The PR is submitted to the correct branch (
dev).✔️ My code follows the code style of this project.
✔️ I've added relevant tests.