MudFabMenu: Stop disabled menu opening on hover - #13909
Merged
Merged
Conversation
danielchalmers
added
the
bug
Hovering a disabled menu opened it and showed its items, even though clicking it did nothing. Hover now checks GetDisabledState(), so a cascaded ParentDisabled counts too. A menu that becomes disabled while open now closes, since its button can no longer toggle it.
danielchalmers
force-pushed
the
fabmenu-disabled-hover
branch
from
September 24, 2026 14:51
f0b21b4 to
b0bbdbe
Compare
Parameter change handlers run after OnParametersSetAsync, so the Open handler reapplied the close icon after the disabled menu had already closed. The handler now follows the current open state.
Member
Author
|
This was discovered during #13908 |
This was referenced Sep 27, 2026
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
OpenOnMouseHoveron (the default), a disabled MudFabMenu opened on hover and showed its items, although clicking it did nothing.GetDisabledState()is true, so a cascadedParentDisabledcounts too.OpenChanged(false). Its button can't toggle it once disabled, so without hover (or on touch) it would otherwise stay open with clickable items. This also meansOpen="true"together withDisabled="true"renders closed.Tests cover hover, hover under a cascaded
ParentDisabled, and becoming disabled while open. The hover and close tests fail without the fix.