-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
MudPopover: Restrict Max Height Adjustments #11680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses issue #11675 by restricting the automatic max-height adjustments in MudPopover to only apply to mud-lists, as originally intended. The changes ensure that max-height adjustments are limited to a minimum of 3x overflowPadding (72px by default) and only occur for list elements.
- Restricts max-height adjustments to only apply when the popover contains a mud-list element
- Introduces a minimum max-height constraint of 3x overflowPadding (72px default)
- Adds debugging console output to track first child elements
|
|
What is the significance of 3x? Does it matter if the user has defined an item size that isn't 24px? Is it possible we should use generic class names instead of |
It was only ever made to be possible to shrink really long lists to the page and was originally set to mud-list. When I refactored it I was improving it and forget to re-enable it. As far as does size matter - no, it just looks dumb when it shrinks less than the size of an item and I wanted to make it more dynamic without complexity so I used overflowPadding that is passed from PopoverOptions. |
|
Just upgraded to 8.10 and this is now causing some of my MudMenus to shrink. How do I go back to having no max height instead of the default 72? |
Do you have a trymud example? Make an issue? It shouldn't shrink unless it's going to exceed the height even after flipping. If you do not want that behavior at all just setting a |
What height is in reference here? Height of the page? I do have a trymud now, just didn't make any issue because I am not sure if bug or I just don't understand the change. |
I will look into it, still think you should make an issue and tag me. For an immediate workaround set |




Resolves #11675
Re-introduce the automatic max-height adjustments to just mud-lists as it was originally intended.
Restricted max-height to 3x overflowPadding (defaults to 24px)
Checklist:
dev).