Skip to content

Conversation

@n0spaces
Copy link
Contributor

Description

Updated _simpletable.scss so the bottom-border: none; rule only applies to immediate child nodes rather than all descendants.

The old selector would apply the rule to all td that descends from tr:last-child, which would cause a nested table to not have row borders if it was in the last row of a MudSimpleTable.

Fixes #11559

How Has This Been Tested?

visually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Code sample:

<MudSimpleTable Dense Outlined Style="width: 300px">
    <tbody>
        <tr>
            <td>foobar</td>
            <td>
                <MudSimpleTable Dense Outlined>
                    <tbody>
                        <tr><td>foo</td><td>1</td></tr>
                        <tr><td>bar</td><td>2</td></tr>
                    </tbody>
                </MudSimpleTable>
            </td>
        </tr>
        <tr>
            <td>foobaz</td>
            <td>
                <MudSimpleTable Dense Outlined>
                    <tbody>
                        <tr><td>foo</td><td>3</td></tr>
                        <tr><td>baz</td><td>4</td></tr>
                    </tbody>
                </MudSimpleTable>
            </td>
        </tr>
    </tbody>
</MudSimpleTable>

Before:
Screenshot 2025-06-27 104848

After:
Screenshot 2025-06-27 104756

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added the bug Unexpected behavior or functionality not working as intended label Jun 27, 2025
@sonarqubecloud
Copy link

Copy link
Member

@danielchalmers danielchalmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart!

@danielchalmers danielchalmers merged commit 04ab5bc into MudBlazor:dev Jun 27, 2025
7 checks passed
@danielchalmers
Copy link
Member

@n0spaces #11628 builds on this, would love your thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MudSimpleTable: Nested tables do not display row borders if they are in the last row of a parent table

3 participants