Skip to content

Conversation

@danielchalmers
Copy link
Member

Description

How Has This Been Tested?

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Min width

image

Arrow gutters

image

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@danielchalmers danielchalmers requested a review from Copilot May 30, 2025 23:46
@github-actions github-actions bot added the enhancement Request for adding a new feature or enhancing existing functionality (not fixing a defect) label May 30, 2025
@danielchalmers
Copy link
Member Author

@versile2 is this more like what you had in mind?

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces new style adjustments to the MudMenu component by adding a minimum width to the menu list and gutters for submenu icons to improve layout consistency.

  • Added a minimum width of 112px to the menu list.
  • Introduced a margin inline-end of 36px for menu items without a submenu icon.

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.13%. Comparing base (137180c) to head (83d157b).
Report is 16 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #11435      +/-   ##
==========================================
+ Coverage   91.10%   91.13%   +0.03%     
==========================================
  Files         465      465              
  Lines       14407    14412       +5     
  Branches     2788     2790       +2     
==========================================
+ Hits        13126    13135       +9     
+ Misses        642      641       -1     
+ Partials      639      636       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@versile2
Copy link
Contributor

@versile2 is this more like what you had in mind?

Exactly what I envisioned yes

@danielchalmers danielchalmers merged commit 5509f51 into MudBlazor:dev May 31, 2025
7 checks passed
@danielchalmers danielchalmers deleted the menu-width branch May 31, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Request for adding a new feature or enhancing existing functionality (not fixing a defect)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants