Skip to content

Conversation

@danielchalmers
Copy link
Member

Description

The submenu in the example was taking up too much space. Changing the display type is the lazy fix.

How Has This Been Tested?

visually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Before:
image

After:
image

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@danielchalmers danielchalmers requested a review from versile2 May 20, 2025 00:54
@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels May 20, 2025
@codecov
Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.10%. Comparing base (13fa8ee) to head (2f2a713).
Report is 16 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #11367      +/-   ##
==========================================
- Coverage   91.11%   91.10%   -0.01%     
==========================================
  Files         465      465              
  Lines       14407    14407              
  Branches     2789     2788       -1     
==========================================
- Hits        13127    13126       -1     
+ Misses        643      642       -1     
- Partials      637      639       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danielchalmers danielchalmers marked this pull request as draft May 20, 2025 16:52
@versile2
Copy link
Contributor

Review or wait? I noticed you changed it to draft.

@danielchalmers
Copy link
Member Author

danielchalmers commented May 20, 2025

Review or wait? I noticed you changed it to draft.

I need to rework it, thanks for your earlier feedback! Got my prs mixed up, this one's still cooking!

@versile2
Copy link
Contributor

Well it doesn't match material design anymore, there would be a 4px padding on left and right of the nested icon. I am a little unclear on width expectations but I know the nesting icon shouldn't be closer than 4px to the longest item.

image

@danielchalmers danielchalmers changed the title MudMenu: Fix excessive submenu width MudMenu: Fix submenu activators being too wide May 22, 2025
@danielchalmers danielchalmers marked this pull request as ready for review May 22, 2025 00:34
@danielchalmers
Copy link
Member Author

Well it doesn't match material design anymore, there would be a 4px padding on left and right of the nested icon. I am a little unclear on width expectations but I know the nesting icon shouldn't be closer than 4px to the longest item.

You're right, but these dense menus don't strictly follow MD as they are too small in general. I would like to change that in the next major

@sonarqubecloud
Copy link

@versile2
Copy link
Contributor

I did not realize that is just Dense. I will say a Dense icon padding and extra width should likely be this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants