Skip to content

Conversation

@versile2
Copy link
Contributor

@versile2 versile2 commented May 7, 2025

Description

Resolves #11293 to ensure when MudPopoverProvider is not the original it still observes properly.
Resolves #11326

How Has This Been Tested?

Visual Tests and setup a complex testing method in the Viewer for PopoverTwoLayoutsTest.razor since this has come up in other PRs, this will give us a way to test.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@versile2 versile2 requested a review from ScarletKuro May 7, 2025 20:19
@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels May 7, 2025
@codecov
Copy link

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.12%. Comparing base (2468042) to head (d96cacc).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #11305   +/-   ##
=======================================
  Coverage   91.12%   91.12%           
=======================================
  Files         465      465           
  Lines       14400    14400           
  Branches     2787     2787           
=======================================
  Hits        13122    13122           
  Misses        642      642           
  Partials      636      636           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ScarletKuro
Copy link
Member

Please, check your indents

@versile2
Copy link
Contributor Author

versile2 commented May 7, 2025

Please, check your indents

Whoops. Every time I use paste it screws it up but most of the time hitting the Beautify fixes it, I did not this time. Let me know if I missed any more.

@sonarqubecloud
Copy link

@ScarletKuro ScarletKuro changed the title PopoverProvider - Multiple Layouts PopoverProvider: Multiple Layouts May 16, 2025
@ScarletKuro ScarletKuro merged commit 34a2365 into MudBlazor:dev May 16, 2025
6 checks passed
@ScarletKuro ScarletKuro deleted the fix/popovertwocontainers branch May 16, 2025 14:13
@Hastaroth1
Copy link

Hello. Is there a general idea of when you expect this to be released?

@versile2
Copy link
Contributor Author

Hello. Is there a general idea of when you expect this to be released?

It varies and I'm not the one that decides that but usually about a month apart for releases. Last release was April 29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dropdowns / Menus Not Appearing After Route Update MudMenu intermittently fails to display menu items in WASM app (regression in v8.6.0)

3 participants