Skip to content

Conversation

@Anu6is
Copy link
Contributor

@Anu6is Anu6is commented Feb 11, 2025

Description

Persian calendar should always display Persian year in the header

Resolves: #10849

How Has This Been Tested?

Visually + unit test

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Feb 11, 2025
@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.91%. Comparing base (13a7f64) to head (bbd7176).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10854   +/-   ##
=======================================
  Coverage   91.91%   91.91%           
=======================================
  Files         427      427           
  Lines       13570    13576    +6     
  Branches     2599     2601    +2     
=======================================
+ Hits        12473    12479    +6     
  Misses        524      524           
  Partials      573      573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro
Copy link
Member

ScarletKuro commented Feb 11, 2025

Please, run dotnet format.
Also seems something is failing.
I'm also hesitant on this line:

if (DateTime.TryParseExact($"{year}-{month}-{day}", "yyyy-M-d", null, DateTimeStyles.None, out var date))

We pass Culture as null why not at least CultureInfo.InvariantCulture, I'm slightly worried that this might depend now on the CultureInfo.CurrentCulture.

@Anu6is
Copy link
Contributor Author

Anu6is commented Feb 11, 2025

The failures aren't from these changes.
I could pass invariant culture, sure

@ScarletKuro
Copy link
Member

ScarletKuro commented Feb 11, 2025

Hm interesting, the formatting comes from unrelated files, seems new SDK?
Should be fixed in a separate PR then.

@ScarletKuro ScarletKuro requested a review from henon February 21, 2025 17:32
@Anu6is Anu6is requested a review from ScarletKuro February 21, 2025 17:35
Copy link
Collaborator

@henon henon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MudDatePicker displays Gregorian year in header when using Persian (fa-IR) culture

3 participants