Skip to content

Conversation

@versile2
Copy link
Contributor

@versile2 versile2 commented Feb 7, 2025

Description

Resolves #10833 with just CSS
Altered existing viewer page to test
Added Docs example for other options

image

How Has This Been Tested?

No additional code added

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended docs Web or code documentation or examples is the main focus PR: needs review labels Feb 7, 2025
@versile2 versile2 requested a review from henon February 7, 2025 17:49
@codecov
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.86%. Comparing base (bd4e4d0) to head (edb5988).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10838      +/-   ##
==========================================
- Coverage   91.86%   91.86%   -0.01%     
==========================================
  Files         427      427              
  Lines       13446    13454       +8     
  Branches     2595     2596       +1     
==========================================
+ Hits        12352    12359       +7     
  Misses        523      523              
- Partials      571      572       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielchalmers
Copy link
Member

CSS should be formatted with 2 spaces

@versile2
Copy link
Contributor Author

versile2 commented Feb 7, 2025

CSS should be formatted with 2 spaces

Fixed.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2025

@henon henon changed the title Datagrid FixedHeader Loading Indicator Sticky Fix MudDataGrid: Fix Loading Indicator scrolls out of view with FixedHeader Feb 8, 2025
@henon henon removed PR: needs review docs Web or code documentation or examples is the main focus labels Feb 8, 2025
@henon henon merged commit f1c6ce0 into MudBlazor:dev Feb 8, 2025
6 checks passed
@henon
Copy link
Collaborator

henon commented Feb 8, 2025

Thanks @versile2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MudDataGrid | Loading indicator can scroll out of the view with FixedHeader

4 participants