-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
MudSelect: Fix ResetAsync #10828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
MudSelect: Fix ResetAsync #10828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #10828 +/- ##
=======================================
Coverage 91.86% 91.86%
=======================================
Files 427 427
Lines 13446 13446
Branches 2595 2595
=======================================
Hits 12352 12352
Misses 523 523
Partials 571 571 ☔ View full report in Codecov by Sentry. |
ScarletKuro
reviewed
Feb 6, 2025
…lazor into 2092-MudSelect-Reset
|
ScarletKuro
approved these changes
Feb 6, 2025
This was referenced Aug 18, 2025
This was referenced Oct 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Description
Calling
ResetAsynconMudSelectclears theValuebut does not clear theSelectedValuescollection.This change overrides the base
ResetValueAsyncand ensure that theSelectedValuescollection is cleared.Additionally, I took the opportunity to rename the
Clearmethod toClearAsync. The existingClearmethod has been marked as obsolete so as not to introduce a breaking change.Resolves: #2092
How Has This Been Tested?
Visual and unit tests
Type of Changes
Checklist
dev).