Skip to content

Conversation

@Anu6is
Copy link
Contributor

@Anu6is Anu6is commented Feb 6, 2025

Description

Calling ResetAsync on MudSelect clears the Value but does not clear the SelectedValues collection.

This change overrides the base ResetValueAsync and ensure that the SelectedValues collection is cleared.

Additionally, I took the opportunity to rename the Clear method to ClearAsync. The existing Clear method has been marked as obsolete so as not to introduce a breaking change.

Resolves: #2092

How Has This Been Tested?

Visual and unit tests

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Feb 6, 2025
@Anu6is Anu6is requested a review from ScarletKuro February 6, 2025 14:19
@codecov
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.86%. Comparing base (d9e44c6) to head (be7742f).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10828   +/-   ##
=======================================
  Coverage   91.86%   91.86%           
=======================================
  Files         427      427           
  Lines       13446    13446           
  Branches     2595     2595           
=======================================
  Hits        12352    12352           
  Misses        523      523           
  Partials      571      571           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MudSelect.Reset() retains SelectedValues

2 participants