Skip to content

Conversation

@peterthorpe81
Copy link
Contributor

@peterthorpe81 peterthorpe81 commented Jan 21, 2025

Fixes a bug that prevented the analyzers HTMLAttributes mode from using a default list of HTML attributes.

Description

The new HTMLAttributes mode of the analyzer isn't using the default list of HTML attributes when the .csproj doesn't contain an alternative list. This is because MudAllowedAttributeList is string.Empty rather than null. This wasn't apparent in testing because I have to manually create the configuration.

How Has This Been Tested?

Updated test code to make the value string.Empty rather than null and tested.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Jan 21, 2025
@sonarqubecloud
Copy link

@ScarletKuro ScarletKuro changed the title Fix analyzer HTMLAttributes mode defaults Analyzer: Fix HTMLAttributes mode defaults Jan 21, 2025
@ScarletKuro ScarletKuro merged commit a39ce35 into MudBlazor:dev Jan 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants