-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
MudDataGrid: remove detrimental ChildRowContent CSS #10581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
danielchalmers
merged 3 commits into
MudBlazor:dev
from
versile2:fix/mudinputinsidedatagrid
Jan 21, 2025
Merged
MudDataGrid: remove detrimental ChildRowContent CSS #10581
danielchalmers
merged 3 commits into
MudBlazor:dev
from
versile2:fix/mudinputinsidedatagrid
Jan 21, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScarletKuro
requested changes
Jan 9, 2025
|
Please, add before and after pic. |
before and after in first comment? |
|
|
Will review after v8 is out |
danielchalmers
approved these changes
Jan 18, 2025
This was referenced Aug 18, 2025
This was referenced Oct 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Unexpected behavior or functionality not working as intended
enhancement
Request for adding a new feature or enhancing existing functionality (not fixing a defect)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.





Description
DataGrid uses CSS to alter the mud-input's it is using for it's cell and cell editing functions. I introduced a css class that ignores the margin portion of that style
mud-table-child-content. I applied that class to the two places in the razor file it absorbs ChildRowContent. Also anytime a dev wants to use a mudtextfield with label they can now just addmud-table-child-contentto the CellClass and it will not scrunch the settings.Resolves #10351
How Has This Been Tested?
Visually, unit tests still operate. Before and After in first comment.
Type of Changes
Checklist
dev).