-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Inputs: Refactor adornment related code #10057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inputs: Refactor adornment related code #10057
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #10057 +/- ##
==========================================
+ Coverage 91.10% 91.19% +0.09%
==========================================
Files 410 411 +1
Lines 12476 12485 +9
Branches 2421 2423 +2
==========================================
+ Hits 11366 11386 +20
+ Misses 565 553 -12
- Partials 545 546 +1 ☔ View full report in Codecov by Sentry. |
|
Maybe a little late to ask this, I know people want this change #8945 (comment) |
|
If I understand correctly this doesn't change the visuals, right? If so, no need. What are the breaking changes @danielchalmers ? |
@ScarletKuro Not making that major change any time soon (despite listing it in the description). Just working on lower level stuff that can be taken advantage of later. Next PR will be changing the CSS so adornments can be stacked more cleanly internally, turning the Clear button into an adornment, and making all adornments roughly the same size |
@henon I think the only break was |
MudInputAdornment; Is this correct? Are we sure about the |
|
Added to v8.0.0 Migration Guide |
Description
Laying the groundwork for future adornment improvements by getting the code updated to raise parity in the different implementations.
See #10046, #8945 for context.
How Has This Been Tested?
Type of Changes
AdornmentColorinMudFieldAdornment Placementproperty, replacing theEdge Edgein order to be more explicitmud-input-adornmentclass directly into MudInputAdornment which now has a CSS buildertabindex=-1to the Clear button in MudMaskmud-input-clear-buttonto the Clear button in MudMaskmud-input-adornment-textclass to the text adornment typeChecklist
dev).