Skip to content

Conversation

@danielchalmers
Copy link
Member

Description

Laying the groundwork for future adornment improvements by getting the code updated to raise parity in the different implementations.

See #10046, #8945 for context.

How Has This Been Tested?

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)
  • Formats certain code/markup to normalize them with other places
  • Hooks up AdornmentColor in MudField
  • MudInputAdornment now accepts a Adornment Placement property, replacing the Edge Edge in order to be more explicit
  • Improves docs for Adornment and Edge enum types
  • Moves mud-input-adornment class directly into MudInputAdornment which now has a CSS builder
  • Adds missing tabindex=-1 to the Clear button in MudMask
  • Adds missing mud-input-clear-button to the Clear button in MudMask
  • Adds missing mud-input-adornment-text class to the text adornment type

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added breaking change This change will require consumer code updates PR: needs review labels Oct 19, 2024
@codecov
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 98.36066% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.19%. Comparing base (6ac51c8) to head (7f1b0f8).
Report is 10 commits behind head on dev.

Files with missing lines Patch % Lines
src/MudBlazor/Components/Input/MudInput.razor.cs 96.15% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10057      +/-   ##
==========================================
+ Coverage   91.10%   91.19%   +0.09%     
==========================================
  Files         410      411       +1     
  Lines       12476    12485       +9     
  Branches     2421     2423       +2     
==========================================
+ Hits        11366    11386      +20     
+ Misses        565      553      -12     
- Partials      545      546       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro requested a review from henon October 20, 2024 07:55
@ScarletKuro
Copy link
Member

Maybe a little late to ask this, I know people want this change #8945 (comment)
But do we need a green light from @Garderoben here?

@henon
Copy link
Collaborator

henon commented Oct 20, 2024

If I understand correctly this doesn't change the visuals, right? If so, no need. What are the breaking changes @danielchalmers ?

@danielchalmers
Copy link
Member Author

danielchalmers commented Oct 20, 2024

Maybe a little late to ask this, I know people want this change #8945 (comment) But do we need a green light from @Garderoben here?

@ScarletKuro Not making that major change any time soon (despite listing it in the description). Just working on lower level stuff that can be taken advantage of later. Next PR will be changing the CSS so adornments can be stacked more cleanly internally, turning the Clear button into an adornment, and making all adornments roughly the same size

@danielchalmers
Copy link
Member Author

danielchalmers commented Oct 20, 2024

If I understand correctly this doesn't change the visuals, right? If so, no need. What are the breaking changes @danielchalmers ?

@henon I think the only break was MudInputAdornment.Edge being replaced with MudInputAdornment.Placement

@ScarletKuro
Copy link
Member

@henon I think the only break was MudInputAdornment.Edge being replaced with MudInputAdornment.Placement

MudInputAdornment; Edge property of type Edge was replaced to Placement of type Adornment.

Is this correct? Are we sure about the Placement property name?

@ScarletKuro ScarletKuro added the v8 label Oct 20, 2024
@danielchalmers
Copy link
Member Author

@henon I think the only break was MudInputAdornment.Edge being replaced with MudInputAdornment.Placement

MudInputAdornment; Edge property of type Edge was replaced to Placement of type Adornment.

Is this correct? Are we sure about the Placement property name?

We used Placement in #9472

@henon henon added hacktoberfest Hacktoberfest 2021 hacktoberfest-accepted Issues and PRs which were accepted as Hacktoberfest submissions hacktoberfest2024 and removed PR: needs review labels Oct 21, 2024
@henon henon changed the title Refactor adornment related code Inputs: Refactor adornment related code Oct 21, 2024
@henon henon merged commit 928d946 into MudBlazor:dev Oct 21, 2024
4 checks passed
@henon henon mentioned this pull request Oct 21, 2024
@henon
Copy link
Collaborator

henon commented Oct 21, 2024

Added to v8.0.0 Migration Guide
#9953

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change This change will require consumer code updates hacktoberfest Hacktoberfest 2021 hacktoberfest2024 hacktoberfest-accepted Issues and PRs which were accepted as Hacktoberfest submissions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants