Feature/#354 deprecation of jql search and evaluate expression endpoints #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`npm fix audit`
RangeError: options.minThreads and options.maxThreads must not conflict Fixed by adding `--minWorkers=8` to `test:unit` in package.json
Only implemented unit test for the newly added function evaluateJiraExpressionUsingEnhancedSearch()
Implemented new function evaluateJiraExpressionUsingEnhancedSearch()
Only implemented unit test for the newly added function evaluateJiraExpressionUsingEnhancedSearch()
Implemented new function evaluateJiraExpressionUsingEnhancedSearch()
MrRefactoring
requested changes
Feb 7, 2025
MrRefactoring
added
the
enhancement
|
To be honest, I was working on these same improvements in parallel, but not all the naming was done as well as you’ve done it, so I suggest merging |
…ion-of-JQL-search-and-Evaluate-expression-endpoints
|
Hi @MrRefactoring, I don't have a strong opinion on the naming. I just copied them from the Jira API documentation and got some inspiration from your existing code. Could you suggest some code or group that you would like me to review for the naming? Otherwise, I think it's fine 👍 |
|
You can start with the methods you’ve already added. After merging with the release branch, the names might get overwritten by my changes, and I’d like to preserve yours |
…ion-of-JQL-search-and-Evaluate-expression-endpoints
nessgor
deleted the
feature/#354-Deprecation-of-JQL-search-and-Evaluate-expression-endpoints
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #354.
issueSearchjiraExpressions