Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ignore_metadata flag propagation for arrays of structs #139

Merged
merged 2 commits into from
Oct 2, 2024
Merged

fix ignore_metadata flag propagation for arrays of structs #139

merged 2 commits into from
Oct 2, 2024

Conversation

jana-starkova
Copy link
Contributor

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added or modified a feature, documentation in docs is updated

Description of changes

Follow up on #133.
The ignore_metadata flag wasn't propagating properly for structfields containing an array of structfields.

SemyonSinchenko
SemyonSinchenko approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution @jana-starkova !

@fpgmaas fpgmaas merged commit 25791ff into MrPowers:main Oct 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpgmaas fpgmaas fpgmaas approved these changes

@SemyonSinchenko SemyonSinchenko SemyonSinchenko approved these changes

@MrPowers MrPowers Awaiting requested review from MrPowers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jana-starkova @fpgmaas @SemyonSinchenko