Nithin/crate merge #404
Merged
Nithin/crate merge #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just ensure that the public interface still makes sense with minimal breaking changes. You can verify the public interface by building the docs (not the book). Also check that shrs_example and plugins still build. In the near future (maybe starting from next release), we should keep track of breaking changes and provide a migration changelog for new releases (see bevy update post for inspiration). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr takes on #356, with the main goal being removing dependency cycles between crates.
The idea is that the dependencies should be one way where no other crate can depend on
shrs_coreexceptshrs.shrs_linewas merged intoshrs_corebecause of the deep interdependency between the two.PosixLangfromshrs_langwas also merged intoshrs_coreremoving that dependency.