Type builtin command #361
Merged
Type builtin command #361
+139
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrPicklePinosaur
requested changes
Jan 31, 2024
| rt: &mut Runtime, | ||
| ) -> anyhow::Result<CmdOutput> { | ||
| let mut name_found = false; | ||
| if !path_search_only { |
There was a problem hiding this comment.
to reduce nesting, i would rephrase this control flow as:
// path search logic
if path_search_only {
return
}
// rest of logic|
|
||
| #[derive(Parser)] | ||
| struct Cli { | ||
| #[arg(short = 'P')] |
There was a problem hiding this comment.
long flags for each of these and also some docs would be nice (we don't need to follow basic type builtin exactly)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
typecommand. Currently it is capable of detecting aliases, builtins, and files in the PATH. It supports four flags:-a,-p,-P, and-t..