Repository navigation
chore: remove committed lavish validation scratch files and ignore the folder - #92
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Remove the scratch files that fork PR #63 (commit 726a1ba) committed by mistake under
.live-lavish-validation/on this public repository, and stop that folder from being committed again.Context: a comparison of this fork with upstream found 9 tracked files there (claims/lavish-10e0fb1e81b6d2c0.claim, deck-template.html, guards.html, lavish-state/server.log, lavish-state/state.json, ordinary.html, reverse.html, suppress.html, unbound.html). They hold local home-directory paths and session tokens for a local test Lavish server that no longer runs. They are test leftovers, not product files.
What Changed
.live-lavish-validation/by mistake:claims/lavish-10e0fb1e81b6d2c0.claim,deck-template.html,guards.html,lavish-state/server.log,lavish-state/state.json,ordinary.html,reverse.html,suppress.html, andunbound.html. These files held local home-directory paths and session tokens for a local Lavish test server..live-lavish-validation/to.gitignoreso git does not track this folder again.Risk Assessment
✅ Low: The change only deletes 9 untracked-in-product scratch files that nothing in the repo references, and adds one .gitignore line that git check-ignore confirms matches the folder; it fully matches the stated intent.
Testing
I drove git, the real consumer of
.gitignore, in throwaway repos built from the base and target trees. All five scenarios passed. Scenario 1: the target has none of the 9 scratch files. Scenario 2: re-creating the same files leavesgit statusclean, andgit add -Astages nothing. Scenario 3: an explicitgit addis refused, and a nested copy of the folder is ignored too. Scenario 4: without the new rule, all 9 files come back as untracked, so the rule is what stops them. Scenario 5: the diff touches only.gitignoreand the 9 files. The transcript is in the evidence directory. I deleted the temp repos, and the worktree is clean. This change has no UI, so there are no screenshots. Note: the files are still in old git history (commit 726a1ba). The intent did not ask for a history rewrite.git ls-files .live-lavish-validation | wc -l→ 0; folder absent on diskgit check-ignore -vattributes every file to .gitignore:20git add .live-lavish-validation/lavish-state/state.jsonrefused with exit 1 and nothing staged;sub/.live-lavish-validation/a.htmlignored by .gitignore:20git rm -ronly → all 9 files shown as??git diff --name-statusshows M .gitignore + 9 D entries;git grepfinds only the new .gitignore line, and the base tree has no other referencesEvidence: git ignore scenario transcript (S1-S5)
Source: git ignore scenario transcript (S1-S5)
Evidence: Re-created scratch files are ignored by the new rule
Evidence: Without the rule (base + deletion only) the files leak back
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
.live-lavish-validation/lavish-state/state.json:1- The deleted files still exist in git history (commit 726a1ba and later). Example: state.json holds artifact_load_token and handoff_token values, and the .claim file holds local home-directory paths. The intent covers only removal from the tree and an ignore rule. The tokens belong to a local 127.0.0.1 Lavish server that no longer runs. No action is needed for this change. A history rewrite would be a separate human decision.✅ **Test** - passed
✅ No issues found.
git ls-files .live-lavish-validation | wc -l→ 0; folder absent on diskgit check-ignore -vattributes every file to .gitignore:20git add .live-lavish-validation/lavish-state/state.jsonrefused with exit 1 and nothing staged;sub/.live-lavish-validation/a.htmlignored by .gitignore:20git rm -ronly → all 9 files shown as??git diff --name-statusshows M .gitignore + 9 D entries;git grepfinds only the new .gitignore line, and the base tree has no other referencesgit diff --name-status d69b2c5a 8add77d9(scope check: only .gitignore + the 9 scratch files)git grep -n live-lavish-validation d69b2c5a -- ':!.live-lavish-validation'(no product code depended on the folder)Disposable repo fromgit archive 8add77d9:git ls-files .live-lavish-validation→ 0 filesRe-created the 9 removed files byte-for-byte from d69b2c5a in the target repo, thengit status --porcelain --untracked-files=all,git add -A && git diff --cached --name-only,git check-ignore -v <each file>Adversarial:git add .live-lavish-validation/lavish-state/state.json(refused, exit 1) and nestedsub/.live-lavish-validation/a.htmlchecked withgit check-ignore -vRegression proof: disposable repo fromgit archive d69b2c5a,git rm -r .live-lavish-validationonly (no ignore rule), re-created files →git statuslists all 9 as untracked✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.