Repository navigation
feat: add opt-in Jev timing policy for native omp compaction - #30
Merged
Merged
Conversation
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
"in terms of cutting over to kun's compact-adviser vs using omp's system, compare and contrast the three options. What are the most relevant decision factors (some assessment of compaction quality would chief among them I would suspect)?" Then: "go for the compaction bakeoff".
This task implements option 3 for the approved three-way omp compaction comparison: Jev integrated into omp's compaction pipeline, rather than replacing omp's compactor.
What Changed
Risk Assessment
✅ Low: The change is explicitly opt-in and confined to native-compaction timing, with bounded deferral and stale-result guards, and no material source defect or intent contradiction was substantiated.
Testing
Both targeted regression invocations passed, and isolated real-omp RPC, tool-loop and TUI scenarios demonstrated opt-in timing policy, native persistence, recovery precedence and cancellation guards. Product transcripts and persisted entries were retained; all disposable resources were removed. No full suite, lint or static analysis ran. Fixture endpoints do not establish model quality or paid usage; no UI layout/copy changed, so terminal evidence rather than screenshots was captured.
Evidence: Validation index, commands, isolation and evidence limitations
Source: Validation index, commands, isolation and evidence limitations
Evidence: Qualifying judgment and persisted native compaction
Source: Qualifying judgment and persisted native compaction
Evidence: Bounded deferral during two real read-tool calls
Source: Bounded deferral during two real read-tool calls
Evidence: Actual read-tool output and native recovery transcript
Source: Actual read-tool output and native recovery transcript
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
bash bin/fm-test-run.sh tests/fm-omp-jev-pipeline.test.shFM_JEV_ADVISER_DIR="$PWD/.fm-adviser-root/node_modules/compact-adviser" bash bin/fm-test-run.sh tests/fm-omp-jev-pipeline.test.shVerified the authorized adviser archive SHA-256 and installed it withnpm install --prefix .fm-adviser-root ~/firstmate/data/fm-compact-adviser-omp/compact-adviser-0.1.11.tgz; copied the static entry into that isolated dependency root.Created disposable marked homes withbin/fm-lab-home.sh createand private sockets withbin/fm-lab-home.sh tmux-dir; launched real omp through privatetmux -L fm-labsessions with isolated HOME, FM_HOME and PI_CODING_AGENT_DIR.Drove the documented static extension through real omp RPC usingprompt,set_auto_compaction,compactandset_modelrequests against disposable loopback model/Jev endpoints.Executed two successful built-inreadcalls within one actual agent loop and observed native threshold compaction after the in-loop advisory deferral.Drove actual provider timeout, context-length error, incomplete length response, permanent failed turn, consent/opt-in guards, structured-secret context, and pending-request invalidation scenarios.Launched the genuine interactive TUI in a 180x50 tmux grid, observed its 60-second idle-compaction attempt, then executed/compact Preserve the isolated checkpoint and recent native history.Retained product transcripts, controller metrics and persisted native compaction entries; stopped private tmux servers and the fixture endpoint, removed all phase-created dependencies/labs/caches, and verified evidence JSON readability and fixture removal.✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.