Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: opaque type is not Send #3

Merged
merged 1 commit into from
Apr 28, 2022
Merged

fix: opaque type is not Send #3

merged 1 commit into from
Apr 28, 2022

Conversation

MrCroxx
Copy link
Owner

@MrCroxx MrCroxx commented Apr 28, 2022

As metioned in rust-lang/rust#93458 , using .await in format! will cause Future not Send. We need to move .await output format! and log! scopes.

Changes:

  • Move .await output format! and log! scopes.
  • Add serde::Serialize and serde::Deserialize for proto structs.
  • Fix Snapshot::is_emtpy.

@MrCroxx MrCroxx added the bug Something isn't working label Apr 28, 2022
@MrCroxx MrCroxx self-assigned this Apr 28, 2022
@MrCroxx MrCroxx enabled auto-merge (squash) April 28, 2022 09:21
@MrCroxx MrCroxx merged commit f44c574 into async Apr 28, 2022
@MrCroxx MrCroxx deleted the xx/fix-opaque-bug branch April 28, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MrCroxx MrCroxx

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MrCroxx