Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing events to MeteoFrance & update French translation #76

Merged
merged 1 commit into from
Feb 19, 2022

Conversation

Nsbx
Copy link
Contributor

@Nsbx Nsbx commented Feb 19, 2022

Hey :)

I finally take a look into the source code to find the complete list of event, instead find them one by one ...
I don't know why I didn't do that directly

Also, I found some invisible char into translation, I replace them by space like other translation.

Fixes: #74

@MrBartusek MrBartusek changed the title Add missing event type + fix invisible char from translation Add missing events to MeteoFrance & update French translation Feb 19, 2022
@MrBartusek MrBartusek merged commit 8f55578 into MrBartusek:master Feb 19, 2022
@MrBartusek
Copy link
Owner

Thanks!

@Lynilia
Copy link
Contributor

Lynilia commented Mar 8, 2022

Also, I found some invisible char into translation, I replace them by space like other translation.

Hello,

Those characters were non-breaking spaces ("espace insécable" in French), they look like normal spaces but are used to prevent line breaks from throwing punctuation alone on a new line.

More info on Wikipedia: en - fr

@MrBartusek
Copy link
Owner

@Lynilia there shouldn't be any multi-line text on the card. If this is a case, it's a bug.

@Lynilia
Copy link
Contributor

Lynilia commented Mar 8, 2022

Hey, this is for error messages, which can wrap depending on the card width and message length.
See the following when using a normal space:
nbsp
And when using a non-breaking space:
nbsp2
French style guides impose the use of non-breaking spaces to prevent the punctuation from being wrapped alone on a new line.
(It is not THAT much of a problem, it just looks better that way)

@Nsbx
Copy link
Contributor Author

Nsbx commented Mar 8, 2022

Oh sorry about that @Lynilia, i know what is an insecable space, but my IDE just said "invisible character".
I think the best practice about that is to use HTML entities (    or  ) like this we know where special symbol are and which symbol are used

@MrBartusek
Copy link
Owner

MrBartusek commented Mar 9, 2022

@Lynilia I actually forgot about this, thanks!

@Nsbx to be honest it seams like this is a French-specific thing so you can go ahead and change it to non-breaking spaces in the translation file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Yellow' alert isn't parsed while using meteoFrance
3 participants