Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redact attributes that are added after span creation #55

Merged
merged 3 commits into from
Sep 17, 2023
Merged

Redact attributes that are added after span creation #55

merged 3 commits into from
Sep 17, 2023

Conversation

Squiry
Copy link
Contributor

@Squiry Squiry commented Sep 17, 2023

Resolves #7

MrAlias
MrAlias previously approved these changes Sep 17, 2023
View reviewed changes
Copy link
Owner

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 🚀

attribute.go Outdated Show resolved Hide resolved
@MrAlias
Update attribute.go
40d8cc9 
Signed-off-by: Tyler Yahn <[email protected]>
@MrAlias MrAlias merged commit 8bd2a27 into MrAlias:main Sep 17, 2023
2 checks passed
@Squiry Squiry deleted the after-create-attr branch September 17, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redact attributes that are added after span creation
2 participants
@Squiry @MrAlias