Adds option to configure the Foreground Done Color #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You may want to represent a different state in some instances, for example a failed operation having a red bar but a successful one with a green bar. Rather than adding the concept of "failed" vs "finished" to the progress bar, this adds a getter and setter like that for the dynamic foreground color.
Adds ForegroundColorError as another option that can be toggled through `pbar.ObservedError = true` or `pbar.WriteErrorLine()`
|
Thanks for the PR @gfs I updated it slightly so that error state is modeled a bit more explicitly Adds This way you don't need to call |
Mpdreamz
approved these changes
Jun 7, 2022
|
Looks great - I like the explicit error option. Looking forward to trying it out when it hits nuget! |
|
New version should be up! Thanks again for the PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to configure the Foreground Done Color in the same Style as the configurable Foreground color.
Adds an example for its usage.
Motivation:
Sometimes a task may fail, but the Done color must be configured ahead of time. The color of the progress bar may then mislead the user into thinking the process was successful when it was not.