Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tick(estimatedDuration, message) does not update EstimatedDuration #89

Closed
JamieKitson opened this issue Sep 6, 2021 · 0 comments · Fixed by #95
Closed

Tick(estimatedDuration, message) does not update EstimatedDuration #89

JamieKitson opened this issue Sep 6, 2021 · 0 comments · Fixed by #95

Comments

@JamieKitson
Copy link

Compare:

		public void Tick(TimeSpan estimatedDuration, string message = null)
		{
			Interlocked.Increment(ref _currentTick);
			FinishTick(message);
		}
		public void Tick(int newTickCount, TimeSpan estimatedDuration, string message = null)
		{
			Interlocked.Exchange(ref _currentTick, newTickCount);
			_estimatedDuration = estimatedDuration;

			FinishTick(message);
		}

public void Tick(TimeSpan estimatedDuration, string message = null)

JamieKitson added a commit to JamieKitson/shellprogressbar that referenced this issue Sep 6, 2021
Tick(estimatedDuration, message) does not update EstimatedDuration Mpdreamz#89
drehtisch added a commit to drehtisch/shellprogressbar that referenced this issue Mar 27, 2022
Mpdreamz pushed a commit that referenced this issue Jun 7, 2022
…ate estimatedDuration (#95)

* Fix #94: EstimatedDuration "overflow" if > 24h

* Fix #89: Tick doesn't update _estimatedDuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant