Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Look and feel of footer #9

Open
Amorpheuz opened this issue Oct 13, 2019 · 12 comments
Open

Improve Look and feel of footer #9

Amorpheuz opened this issue Oct 13, 2019 · 12 comments
Labels
hacktoberfest Curated issues for #hacktoberfest participants

Comments

@Amorpheuz
Copy link
Member

Is your feature request related to a problem? Please describe.
Courtesy of the minima theme, our current site footer is pretty plain and simple. It would be great to have it look as information-rich as the Wordpress Blog.

Describe the solution you'd like
The current Wordpress theme's footer contains a ton of information in it. We should add this information to the Jekyll site's footer too!
Screenshot_20191013_161644

Additional context
Be sure to take care of both the desktop and the mobile views for the same and have the correct links.

@Amorpheuz
Copy link
Member Author

The sign-up for the newsletter component should be kept as a separate thing in my opinion.

@Amorpheuz
Copy link
Member Author

Part of the issues mentioned by @karx in #2. He is also interested in tackling the issue and looking for suggestions in case any are missed.

@asdofindia asdofindia added the hacktoberfest Curated issues for #hacktoberfest participants label Oct 13, 2019
@ultrinnan
Copy link

Hello, can I help with this?
In my opinion there should be more space between menu items, and on the right column we can put any widget, f.e. newsletter subscription

@Amorpheuz
Copy link
Member Author

Hey! @ultrinnan Sure you can help, I hope you and @karx can collaborate on the widget idea and figure it out.

@karx
Copy link
Contributor

karx commented Oct 16, 2019

@ultrinnan Sounds great !
I am the loop. Let's get building

@ultrinnan
Copy link

@karx do you have some subscription code? like mailchimp or something similar that we can use for widget?

@karx
Copy link
Contributor

karx commented Oct 16, 2019

Yes I have a MailChimp account we could use for testing and development, but that would not be enough. Let's try and understand how the current sub box works and try and use that itself as functional part.

@ultrinnan
Copy link

ok, so to summarise - I will change footer sizings and will add widget box for subscription, right?

@karx
Copy link
Contributor

karx commented Oct 16, 2019

For the Footer.
Yes, that would entail updating/creating the footer.html template which would exist in the _includes directory of this page.

@karx
Copy link
Contributor

karx commented Oct 16, 2019

And for the newsletter subscription, a good way could be to create it as an include.
Say: _includes/newseller-subscription.html (Custom you will have to create)

And also updating the layout of the home page, _layouts/home.html, to use this.

@karx
Copy link
Contributor

karx commented Oct 16, 2019

The files we need to edit like
_layout/home.html, _includes/footer.html are imported from the gem, we use for our theme minima.

#2 Aims to bring these files over to our working jekyll directory so it is eaiser for us to make updates and have better clarity in this repo.

In the meantime, you dont have to wait up, feel free to make/copy/create all the needed in _layouts and _includes

There are a bunch of folks in this repo who would help out incase of any merge conflicts (rare these days) or any similar problems.
Also Feel free to ping me.

@ultrinnan
Copy link

ok, got it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Curated issues for #hacktoberfest participants
Projects
None yet
Development

No branches or pull requests

4 participants