Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jekyll Migration | Theme fix #2

Closed
karx opened this issue Oct 11, 2019 · 12 comments
Closed

Jekyll Migration | Theme fix #2

karx opened this issue Oct 11, 2019 · 12 comments

Comments

@karx
Copy link
Contributor

karx commented Oct 11, 2019

As I see from the current codebase, we are using the minima theme, which is a good choice to start with.
If anyone wants to recommend any other theme, please feel free to do that here.

In the meantime, the following custom layouts would be needed: (to be added in _layouts)

  • the landing/homepage
    This would include a paginated listing of all the "posts"
    image

  • Posts-detail page
    image

And the following in includes to be reused in the layouts: (to be added in _includes)

  • header
    image

  • footer
    image

Let me know if I missing or overlooking something here.
I few thumbs up before I start the dev seems like a good idea to me.

Note: I am looking at https://blog.mozillaindia.org/ for the target look and feel of this.

@asdofindia
Copy link
Contributor

The theme on wordpress is https://github.com/craigcook/frontierline-theme (the just "Frontierline" theme)

@Amorpheuz
Copy link
Member

image

The previous and next functionality on posts would be nice too along with recent articles! Categories can be added once the functionality for the same is up.

I think we should have an issue with a task list which can be added to by maintainers based on suggestions along with who is working on what and what is up for grabs? It could be a single issue with a task list or a bunch of issues and the list being in projects as seen fit.

The repo can still take benefit of the ongoing Hacktoberfest to rapidly progress!

@asdofindia
Copy link
Contributor

I'm on board @Amorpheuz. Please make multiple small issues rather than one big list. Shall give you triage access if you wish.

@Amorpheuz
Copy link
Member

Sounds great! I will get a bunch of issues up over the weekend which will be up for grabs. I will also get the ones mentioned by @karx above into their separate issues and assign him the same.

@karx
Copy link
Contributor Author

karx commented Oct 12, 2019

@Amorpheuz sounds like a great plan!
Looking forward to assigning some of them to myself.

@karx
Copy link
Contributor Author

karx commented Oct 12, 2019

In my other Jekyll project I switched to using the theme as a regular-themes as compared to a gem-based theme. This translate to having all files our present in your Jekyll site directory. Makes things more explicit.

@Amorpheuz
Copy link
Member

regular-themes do sound better in comparison to gem-based theme. I think it will make it easier for newcomers to Jekyll to jump into contributing. Though, I haven't used Jekyll very extensively and am unaware of the pros and cons of the two.

@asdofindia
Copy link
Contributor

Regular theme is totally the right thing for our very much customized website. It is gem based at the moment only because that is the default on jekyll new

@cseas
Copy link
Contributor

cseas commented Oct 14, 2019

https://github.com/craigcook/frontierline-theme/tree/master/themes/frontierline

Is this the theme we're referring for our migration?

@asdofindia asdofindia mentioned this issue Oct 16, 2019
4 tasks
@srishti-nema
Copy link
Contributor

I would like to work on this. How can I convert this theme to a gem-based theme and then to a regular one?

@karx
Copy link
Contributor Author

karx commented Oct 16, 2019

Hi @srishti-nema thanks for taking the initiative.

The best way imo for now, would be to just copy the files from the theme gem’s directory into our Jekyll site directory.

Mostly the files in _layout namely:

and _includes

I would recommend just for now, changing the almost lorem ipsum text from the theme to MozillaIndia Blog, and raising a PR.

This would really help move this process.

Reading more about how themes work: https://jekyllrb.com/docs/themes/. All is here.

@karx
Copy link
Contributor Author

karx commented Oct 16, 2019

Closing this issue in as now:

@karx karx closed this as completed Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants