Skip to content

Add Mozfest Hero Cta Label#7676

Merged
TheoChevalier merged 6 commits intomainfrom
feature/mozfest-hero-updates
Oct 29, 2021
Merged

Add Mozfest Hero Cta Label#7676
TheoChevalier merged 6 commits intomainfrom
feature/mozfest-hero-updates

Conversation

@stevedya
Copy link
Copy Markdown
Collaborator

@stevedya stevedya commented Oct 22, 2021 •
edited
Loading

Add new label functionality for Mozfest hero's cta
Closes #
Related PRs/issues #7432

Link to sample test page:

Checklist

Remove unnecessary checks

Changes in Models:

@mofodevops mofodevops temporarily deployed to foundation-s-feature-mo-bdturu October 22, 2021 17:20 Inactive
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 22, 2021

This PR introduces visual differences. Click here to inspect the diffs.

TheoChevalier
TheoChevalier requested changes Oct 22, 2021
View reviewed changes
danielfmiranda
danielfmiranda approved these changes Oct 22, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@danielfmiranda danielfmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stevedya!

Thanks for tagging me in this, I just took a look at the code, and also tested out adding a custom message for the button. Everything is working well! Approved 👍

@mofodevops mofodevops temporarily deployed to foundation-s-feature-mo-bdturu October 22, 2021 21:45 Inactive
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 22, 2021

This PR introduces visual differences. Click here to inspect the diffs.

TheoChevalier
TheoChevalier approved these changes Oct 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TheoChevalier TheoChevalier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good for localization now :)

@TheoChevalier TheoChevalier temporarily deployed to foundation-s-feature-mo-bdturu October 27, 2021 10:12 Inactive
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 27, 2021

This PR introduces visual differences. Click here to inspect the diffs.

@TheoChevalier
Copy link
Copy Markdown
Contributor

TheoChevalier commented Oct 27, 2021

Hey @stevedya , fyi it looks like the migration isn’t applying nicely anymore, I think it’s conflicting with the main branch

@mofodevops mofodevops temporarily deployed to foundation-s-feature-mo-bdturu October 28, 2021 21:20 Inactive
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 28, 2021

This PR introduces visual differences. Click here to inspect the diffs.

@mofodevops mofodevops temporarily deployed to foundation-s-feature-mo-bdturu October 28, 2021 21:25 Inactive
@b-ggs
Copy link
Copy Markdown
Collaborator

b-ggs commented Oct 28, 2021

Hey @TheoChevalier, I've updated and renumbered the migration in this PR!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 28, 2021

This PR introduces visual differences. Click here to inspect the diffs.

@TheoChevalier
Copy link
Copy Markdown
Contributor

TheoChevalier commented Oct 29, 2021

Thanks!

@TheoChevalier TheoChevalier merged commit 434f29d into main Oct 29, 2021
@TheoChevalier TheoChevalier deleted the feature/mozfest-hero-updates branch October 29, 2021 07:49
This was referenced Jun 3, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheoChevalier TheoChevalier TheoChevalier approved these changes

@danielfmiranda danielfmiranda danielfmiranda approved these changes

@b-ggs b-ggs Awaiting requested review from b-ggs

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stevedya @TheoChevalier @b-ggs @danielfmiranda @mofodevops