[7417] FE - Mozfest Community directory tabs#7650
Merged
stevedya merged 16 commits intofeature/fe-be-mozfest-community-directoryfrom Oct 21, 2021
Merged
[7417] FE - Mozfest Community directory tabs#7650stevedya merged 16 commits intofeature/fe-be-mozfest-community-directoryfrom
stevedya merged 16 commits intofeature/fe-be-mozfest-community-directoryfrom
Conversation
siimonevans
reviewed
Oct 21, 2021
Collaborator
siimonevans
left a comment
siimonevans
left a comment
There was a problem hiding this comment.
Looks great @stevedya though I haven't been able to run this locally - suggest you get a second pair of eyes on the JS if possible.
source/js/components/tabbed-profile-directory/loading-spinner.jsx
Outdated
Show resolved
Hide resolved
Pomax
added a commit
that referenced
this pull request
Dec 15, 2021
* Create Pulse Filter snippet * Make PulseFilter snippet migration * Add TabbedProfileDirectory block, which is a generic ProfileDirectory block * Add tabbed profile directory to MozFest pages * Make migration adding new block to Mozfest pages' body * Remove duplicate import * [7417] FE - Mozfest Community directory tabs (#7650) * Profile directory nav start * Add isues to cards and filter for profile types * Convert profile cards to tailwind * directory listing styling * Start react setup for tabbed profile directory filtering * start adding subfilters to directory properties * Create pulse profile component, hook up tabbed profile directory to api * Filtering, back button, active button when no filter * Dropdown styling for subfilters * profile subfiltering functionality * renaming * Create components for profile directory react items * Revert directory blocks to how they were * Filters nav horizontal scroll on mobile * Remove extra directory nav buttons used for testing * Code cleanups as per feedback * Add screen reader text for profile cards * Squashed commit of the following: commit 3530887 Author: Steve <steven_ts@hotmail.com> Date: Thu Dec 2 16:16:39 2021 -0700 Update filters nav spacing on mobile, adjust help text on Tabbed Profile Directory commit 7ddbe3e Author: Steve <steven_ts@hotmail.com> Date: Wed Nov 3 22:48:30 2021 -0600 Pulse profile social icons alignment commit 45e62c3 Author: Steve <steven_ts@hotmail.com> Date: Wed Nov 3 22:46:03 2021 -0600 Fixes as per feedback, custom checkboxes, subfilter dropdown width commit 03ceb29 Author: Steve <steven_ts@hotmail.com> Date: Thu Oct 21 15:56:08 2021 -0600 Code cleanups as per feedback commit 17dc691 Author: Steve <steven_ts@hotmail.com> Date: Wed Oct 20 16:16:07 2021 -0600 Remove extra directory nav buttons used for testing commit 7a27559 Author: Steve <steven_ts@hotmail.com> Date: Wed Oct 20 16:07:39 2021 -0600 Filters nav horizontal scroll on mobile commit 0383eee Author: Steve <steven_ts@hotmail.com> Date: Wed Oct 20 13:42:30 2021 -0600 Revert directory blocks to how they were commit 73fa75e Author: Steve <steven_ts@hotmail.com> Date: Wed Oct 20 13:34:51 2021 -0600 Create components for profile directory react items commit 7ca188c Author: Steve <steven_ts@hotmail.com> Date: Tue Oct 19 22:26:17 2021 -0600 renaming commit 89df5e1 Author: Steve <steven_ts@hotmail.com> Date: Tue Oct 19 22:03:47 2021 -0600 profile subfiltering functionality commit c067772 Author: Steve <steven_ts@hotmail.com> Date: Tue Oct 19 01:25:16 2021 -0600 Dropdown styling for subfilters commit 8d4ebc6 Author: Steve <steven_ts@hotmail.com> Date: Mon Oct 18 22:38:46 2021 -0600 Filtering, back button, active button when no filter commit 8785af7 Author: Steve <steven_ts@hotmail.com> Date: Mon Oct 18 16:50:56 2021 -0600 Create pulse profile component, hook up tabbed profile directory to api commit d1bfcc4 Author: Steve <steven_ts@hotmail.com> Date: Mon Oct 18 10:08:29 2021 -0600 start adding subfilters to directory properties commit f5b94ca Author: Steve <steven_ts@hotmail.com> Date: Fri Oct 15 16:22:07 2021 -0600 Start react setup for tabbed profile directory filtering commit e8f8147 Author: Steve <steven_ts@hotmail.com> Date: Thu Oct 7 18:42:21 2021 -0600 directory listing styling commit be1170f Author: Steve <steven_ts@hotmail.com> Date: Thu Oct 7 18:13:18 2021 -0600 Convert profile cards to tailwind commit 7c94a66 Author: Steve <steven_ts@hotmail.com> Date: Thu Oct 7 16:22:11 2021 -0600 Add isues to cards and filter for profile types commit 724bdcc Author: Steve <steven_ts@hotmail.com> Date: Wed Oct 6 12:42:34 2021 -0600 Profile directory nav start * resolved merge conflicts * Update a tags in profile directory to pass linting tests, update help text of profile directory * [7421] update migration * [7421] fix migrations following main merge Co-authored-by: Sharmaine Lim <amanda.lim@torchbox.com> Co-authored-by: Steve Stein <steven_ts@hotmail.com> Co-authored-by: Rich <rich.brennan@torchbox.com> Co-authored-by: Daniel Miranda <daniel@mozillafoundation.org> Co-authored-by: Rich Brennan <richbrennan@users.noreply.github.com> Co-authored-by: Pomax <pomax@nihongoresources.com>
This was referenced Jun 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is intended for FE review from Torchbox. Then will be merged with the BE branch for the mozilla team review as a whole.
Closes #
Related PRs/issues #7421
Link to sample test page:
Checklist
Remove unnecessary checks
Documentation: