Skip to content

7473 change "all" category on mobile to a more indicative text #7570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pomax merged 2 commits into from
Oct 7, 2021
Merged

7473 change "all" category on mobile to a more indicative text #7570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4604e7a
7473 change "all" category on mobile to a more indicative text
fessehaye Oct 7, 2021
03e2b2c
Merge branch 'pni-q3-2021' into 7473-nav
fessehaye Oct 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions network-api/networkapi/wagtailpages/templates/buyersguide/bg_base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,9 @@
<div class="row">
<div class="col">
{% if pagetype == "product" or pagetype == "about" %}
<a class="multipage-link active" href="{% relocalized_url home_page.localized.url %}">{% trans "All" %}</a>
<a class="multipage-link active" data-mobile="{% trans "All Categories" %}" href="{% relocalized_url home_page.localized.url %}">{% trans "All" %}</a>
{% else %}
<a class="multipage-link {% if not category %} active{% endif %}" href="{% relocalized_url home_page.localized.url %}">{% trans "All" %}</a>
<a class="multipage-link {% if not category %} active{% endif %}" data-mobile="{% trans "All Categories" %}" href="{% relocalized_url home_page.localized.url %}">{% trans "All" %}</a>
{% endif %}

{% for cat in categories %}
Expand Down
4 changes: 3 additions & 1 deletion source/js/foundation/inject-react/multipage-nav.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ export default (apps) => {
if (targetNode && multipageLinks.length) {
let links = Array.from(multipageLinks).map((link) => {
return {
label: link.textContent.trim(),
label: link.dataset.mobile
? link.dataset.mobile.trim()
: link.textContent.trim(),
href: link.getAttribute(`href`),
isActive: !!link.getAttribute(`class`).match(/active/),
};
Expand Down