Add character limit widget to blog titles & homepage headline#7561
Merged
TheoChevalier merged 2 commits intomainfrom Oct 6, 2021
Merged
Add character limit widget to blog titles & homepage headline#7561TheoChevalier merged 2 commits intomainfrom
TheoChevalier merged 2 commits intomainfrom
Conversation
TheoChevalier
force-pushed
the
blog-title-soft-limit
branch
from
4e9c7c1 to
acd149f
Compare
Contributor
Author
|
Hey @kristinashu, added you as a reviewer to make sure this covers the initial discussion in #4984 |
|
Thank you Theo! I'm actually going to assign this to @beccaklam since she is back now and opened the original ticket many moons ago :) |
kristinashu
requested review from
beccaklam
and removed request for
kristinashu
beccaklam
approved these changes
Oct 5, 2021
beccaklam
left a comment
beccaklam
left a comment
There was a problem hiding this comment.
This looks good to me! Exciting to see this was implemented 👍 💯
danielfmiranda
approved these changes
Oct 5, 2021
Collaborator
danielfmiranda
left a comment
danielfmiranda
left a comment
There was a problem hiding this comment.
Hi @TheoChevalier!
Also tested this out and can confirm it works. Approved!
|
This PR introduces visual differences. Click here to inspect the diffs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7560, but in reality, addresses #4984
Can be tested on https://foundation-s-blog-title-cltt2f.herokuapp.com/cms/pages/13/edit/
Can be tested on https://foundation-s-blog-title-cltt2f.herokuapp.com/cms/pages/3/edit/