Skip to content

New localization approach for People voted #7554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielfmiranda merged 4 commits into from
Oct 5, 2021
Merged

New localization approach for People voted #7554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
de92b22
New localization approach for People voted
TheoChevalier Oct 4, 2021
decb470
remove extra spaces
TheoChevalier Oct 4, 2021
e623d07
Simplify string
TheoChevalier Oct 4, 2021
d870200
Update most_voted_rating.html
TheoChevalier Oct 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 24 additions & 18 deletions network-api/networkapi/wagtailpages/templates/fragments/most_voted_rating.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,25 @@
{% load i18n localization %}
{% load i18n %}

{% comment %}

{% endcomment %}

<a class="body-small" href="#creepiness-vote"> {% trans "People voted" context "This string is followed by the creepiness that most people voted, as well as the percentage of people that voted for that ranking" %} </a>
<span class="body-small pl-1"> {{ people_voted|floatformat:"0" }}%</span>
{% if most_voted_rating == 4 %}
<span class="body-small pl-1 people-voted super-creepy"> {% trans "super creepy" %}</span>
{% elif most_voted_rating == 3 %}
<span class="body-small pl-1 people-voted very-creepy"> {% trans "very creepy" %}</span>
{% elif most_voted_rating == 2 %}
<span class="body-small pl-1 people-voted somewhat-creepy"> {% trans "somewhat creepy" %}</span>
{% elif most_voted_rating == 1 %}
<span class="body-small pl-1 people-voted a-little-creepy"> {% trans "a little creepy" %}</span>
{% elif most_voted_rating == 0 %}
<span class="body-small pl-1 people-voted not-creepy"> {% trans "not creepy" %}</span>
{% endif %}
<span class="body-small">
{% if most_voted_rating == 4 %}
{% blocktrans with link_attrs=' class="body-small" href="#creepiness-vote"' vote_percent=people_voted|floatformat:"0" rating_attrs=' class="people-voted super-creepy"' trimmed %}
<a {{ link_attrs }}>People voted</a> {{ vote_percent }}% <span {{ rating_attrs }}>super creepy</span>
{% endblocktrans %}
{% elif most_voted_rating == 3 %}
{% blocktrans with link_attrs=' class="body-small" href="#creepiness-vote"' vote_percent=people_voted|floatformat:"0" rating_attrs=' class="people-voted very-creepy"' trimmed %}
<a {{ link_attrs }}>People voted</a> {{ vote_percent }}% <span {{ rating_attrs }}>very creepy</span>
{% endblocktrans %}
{% elif most_voted_rating == 2 %}
{% blocktrans with link_attrs=' class="body-small" href="#creepiness-vote"' vote_percent=people_voted|floatformat:"0" rating_attrs=' class="people-voted somewhat-creepy"' trimmed %}
<a {{ link_attrs }}>People voted</a> {{ vote_percent }}% <span {{ rating_attrs }}>somewhat creepy</span>
{% endblocktrans %}
{% elif most_voted_rating == 1 %}
{% blocktrans with link_attrs=' class="body-small" href="#creepiness-vote"' vote_percent=people_voted|floatformat:"0" rating_attrs=' class="people-voted a-little-creepy"' trimmed %}
<a {{ link_attrs }}>People voted</a> {{ vote_percent }}% <span {{ rating_attrs }}>a little creepy</span>
{% endblocktrans %}
{% elif most_voted_rating == 0 %}
{% blocktrans with link_attrs=' class="body-small" href="#creepiness-vote"' vote_percent=people_voted|floatformat:"0" rating_attrs=' class="people-voted not-creepy"' trimmed %}
<a {{ link_attrs }}>People voted</a> {{ vote_percent }}% <span {{ rating_attrs }}>not creepy</span>
{% endblocktrans %}
{% endif %}
</span>
2 changes: 1 addition & 1 deletion source/sass/buyers-guide/views/product.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@
.mozilla-says,
.people-voted {
&::after {
content: " ";
content: "";
display: inline-block;
width: 1.5em;
height: 1.5em;
Expand Down