[7425] FE - Session Slider#7538
Merged
stevedya merged 13 commits intofeature/fe-be-mozfest-session-sliderfrom Oct 25, 2021
Merged
[7425] FE - Session Slider#7538stevedya merged 13 commits intofeature/fe-be-mozfest-session-sliderfrom
stevedya merged 13 commits intofeature/fe-be-mozfest-session-sliderfrom
Conversation
stevedya
force-pushed
the
feature/7425-session-slider
branch
from
7e5b767 to
8e501e5
Compare
stevedya
changed the base branch from
feature/fe-be-mozfest-session-slider
to
feature/7424-be-mozfest-session-slider
stevedya
changed the base branch from
feature/7424-be-mozfest-session-slider
to
feature/be-fe-mozfest-current-events-slider
janehughes
approved these changes
Oct 6, 2021
network-api/networkapi/mozfest/templates/mozfest/mozfest-base.html
Outdated
Show resolved
Hide resolved
b-ggs
force-pushed
the
feature/be-fe-mozfest-current-events-slider
branch
from
6716938 to
577d28a
Compare
stevedya
changed the base branch from
feature/be-fe-mozfest-current-events-slider
to
feature/fe-be-mozfest-session-slider
stevedya
force-pushed
the
feature/7425-session-slider
branch
from
2eeee25 to
71b6209
Compare
stevedya
force-pushed
the
feature/7425-session-slider
branch
from
71b6209 to
aa99635
Compare
Pomax
added a commit
that referenced
this pull request
Nov 16, 2021
* Add common reusable link blocks * BE: Mozfest Session Slider * [7425] FE - Session Slider (#7538) * video play on hover styling * Minor spacing * Add session carousel BE variables * Cleanup testing data * Move play triangle into template * End for loop * Session slider template location * Move styles into mozfest.scss to match event slider PR * Add settings to match events carousel * Adjust padding and grids of carousel * Adjust navigation styles * Add video image thumbnail for testing * Hook up video to session cards * Move fragments to avoid conflicts * Migrate from ListBlock to StreamBlock * Remove newline * Add author_subheading to template * Update migrations * Change title font weight to 600 #7515 (review) * Remove tailwind config changes * Remove fill-rule and clip-rule from template #7515 (comment) * Use blocks instead of comments in block template #7515 (comment) * Set session item title bottom-margin to 12px #7515 (review) * Fix issues with the session card erroneously linking to the video instead of the actual link #7515 (review) * Change mobile navigation active bullet color to #0d10bf #7515 (comment) * Hide play button when there is no video #7515 (review) * Add button, make button not required * Update migrations * Update migrations Co-authored-by: Steve Stein <steven_ts@hotmail.com> Co-authored-by: Pomax <pomax@nihongoresources.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7425
Related PRs/issues #7423
Checklist
Remove unnecessary checks
Documentation: