Fix wagtail-localize crash when there’s a search description on PNI products#7525
Merged
Fix wagtail-localize crash when there’s a search description on PNI products#7525
Conversation
|
This PR introduces visual differences. Click here to inspect the diffs. |
Pomax
approved these changes
Sep 29, 2021
Contributor
Pomax
left a comment
Pomax
left a comment
There was a problem hiding this comment.
good find, let's make sure we file this on the wagtail side as a bug, too, because that should definitely warn on startup
This was referenced Jun 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7519
The field was duplicated, making wagtail-localize duplicate the translation, and crashing because of that.
Was able to confirm it fixes it for Signal with a copy of the staging db (hat tip to you)