make sure locale fallback for get_entries gets assigned to the correct variable#7482
Merged
danielfmiranda merged 3 commits intomainfrom Sep 24, 2021
Merged
make sure locale fallback for get_entries gets assigned to the correct variable#7482danielfmiranda merged 3 commits intomainfrom
danielfmiranda merged 3 commits intomainfrom
Conversation
Pomax
commented
Sep 24, 2021
|
This PR introduces visual differences. Click here to inspect the diffs. |
1 similar comment
|
This PR introduces visual differences. Click here to inspect the diffs. |
danielfmiranda
temporarily deployed
to
foundation-s-fix-load-m-lysqbr
danielfmiranda
approved these changes
Sep 24, 2021
Collaborator
danielfmiranda
left a comment
danielfmiranda
left a comment
There was a problem hiding this comment.
Hi Pomax! Just tested this and it seems to be working well. Approved!
|
This PR introduces visual differences. Click here to inspect the diffs. |
stevedya
pushed a commit
that referenced
this pull request
Sep 27, 2021
…t variable (#7482) * make sure locale fallback for get_entries gets assigned to the correct variable * Update network-api/networkapi/wagtailpages/pagemodels/index.py Co-authored-by: Daniel Miranda <manieldiranda@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7481
To test, you'll need a copy of the stage db, as
load_fake_datadoes not have enough blog posts to reproduce this behaviour.STR:
/blogpageCompared to the current behaviour on https://foundation.mozilla.org/blog where clicking the button causes a server error 500 on the Fetch url (see dev tools "network tab" when clicking the button to confirm that error).