Skip to content

7387 Update typesetting styling#7462

Merged
fessehaye merged 4 commits intopni-q3-2021from
7387-type
Sep 24, 2021
Merged

7387 Update typesetting styling#7462
fessehaye merged 4 commits intopni-q3-2021from
7387-type

Conversation

@fessehaye
Copy link
Contributor

@fessehaye fessehaye commented Sep 23, 2021

@fessehaye fessehaye requested review from Pomax and nancyt1 September 23, 2021 17:16
@mofodevops mofodevops temporarily deployed to foundation-s-7387-type-qj2rqd3 September 23, 2021 17:16 Inactive
@Pomax
Copy link
Contributor

Pomax commented Sep 23, 2021

@fessehaye it looks like there's some commits in your commit log that shouldn't be there, can you rebase from current pni-q3-2021?

Pomax
Pomax previously requested changes Sep 23, 2021
Copy link
Contributor

@Pomax Pomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but those "README" commits should not be in this PR.

@mofodevops mofodevops temporarily deployed to foundation-s-7387-type-qj2rqd3 September 23, 2021 21:05 Inactive
@fessehaye fessehaye requested a review from Pomax September 23, 2021 22:36
Copy link
Contributor

@Pomax Pomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R+ from me

@mofodevops mofodevops temporarily deployed to foundation-s-7387-type-qj2rqd3 September 24, 2021 17:27 Inactive
@fessehaye fessehaye merged commit 020daf3 into pni-q3-2021 Sep 24, 2021
@fessehaye fessehaye deleted the 7387-type branch September 24, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants