Conversation
sabrinang
left a comment
sabrinang
left a comment
There was a problem hiding this comment.
@fessehaye Which specific product page URL in the deployment should review? When I click on a product it is Bad Request (400) for me.
danielfmiranda
left a comment
danielfmiranda
left a comment
There was a problem hiding this comment.
Hey Simon! Looks good to me, approving!
sabrinang
left a comment
sabrinang
left a comment
There was a problem hiding this comment.
The text contents/updates/related products should align with the 8 col grid so it seems should be a bit wider:
(I used a bootstrap grid overlay browser extension to check)
In the figma mockup, you can also go to View > Show Layout Grids for alignment reference
fessehaye
force-pushed
the
7393-content-width
branch
from
4c6e700 to
4106be9
Compare
fessehaye
force-pushed
the
7393-content-width
branch
from
4106be9 to
6502670
Compare
sabrinang
left a comment
sabrinang
left a comment
There was a problem hiding this comment.
- the cut out sections can align to the edge of column 2 and 11 for the top section and dotted banner below
- the content below the dotted banner will be the same width as the content above to align with edge of column 3 and 10 as you have updated it
- highlighted in pink lines for your reference
fessehaye
force-pushed
the
7393-content-width
branch
from
6502670 to
aa2272c
Compare
sabrinang
left a comment
sabrinang
left a comment
There was a problem hiding this comment.
Cut outs are good now but the text after the dotted banner should also align (similarly to text above to the edge of col 3 and 10):
fessehaye
force-pushed
the
7393-content-width
branch
from
aa2272c to
2919018
Compare
Fixed padding revision Changes Updates
fessehaye
force-pushed
the
7393-content-width
branch
from
2919018 to
4c3d777
Compare
5 participants
Closes #7393