Skip to content

updated border to render mobile buttons correctly#7230

Merged
danielfmiranda merged 1 commit intomasterfrom
7195-mobile-btn-fix
Aug 16, 2021
Merged

updated border to render mobile buttons correctly#7230
danielfmiranda merged 1 commit intomasterfrom
7195-mobile-btn-fix

Conversation

@danielfmiranda
Copy link
Collaborator

@danielfmiranda danielfmiranda commented Aug 16, 2021

Closes #7195

Link to sample test page: https://foundation-s-7195-mobil-wqnmrs.herokuapp.com/en/

Steps to test:

  1. Visit https://foundation-s-7195-mobil-wqnmrs.herokuapp.com/en/
  2. Resize the window to mobile width
  3. Click the menu icon in the top left of the page
  4. The links that then appear underneath, should have a white border on the bottom if active or hovered over. The rest of them should just be white text.

Screen Shot 2021-08-16 at 12 03 30 PM

  1. If the links appear correctly, testing is done!

Checklist

Changes in Models:

@mofodevops mofodevops temporarily deployed to foundation-s-7195-mobil-wqnmrs August 16, 2021 18:49 Inactive
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

Copy link
Contributor

@fessehaye fessehaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link
Collaborator

@nancyt1 nancyt1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links looks good!

@danielfmiranda danielfmiranda merged commit a04bb19 into master Aug 16, 2021
@danielfmiranda danielfmiranda deleted the 7195-mobile-btn-fix branch August 16, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mobile menu items have a weird border

4 participants