Half the gap by removing the spacing from the hidden header#7218
Half the gap by removing the spacing from the hidden header#7218danielfmiranda merged 7 commits intomainfrom
Conversation
|
This PR introduces visual differences. Click here to inspect the diffs. |
1 similar comment
|
This PR introduces visual differences. Click here to inspect the diffs. |
danielfmiranda
left a comment
There was a problem hiding this comment.
Hi Kalob! Thanks for tagging me in this and leaving easy to follow testing instructions.
I have taken a look at the page on mobile, and can confirm that the height is smaller than what it originally was.
I also took a look at the code, and everything looks good to me! Approving 👍
|
This PR introduces visual differences. Click here to inspect the diffs. |
|
This PR introduces visual differences. Click here to inspect the diffs. |
|
This PR introduces visual differences. Click here to inspect the diffs. |
|
Hey, sorry I didn't look at this sooner. I still see "no such app" at https://foundation-s-7110-halve-bn8dnw.herokuapp.com/en/campaigns/regrets-reporter/findings/ |
|
We need a working Review App for this. Moving to |
|
This PR introduces visual differences. Click here to inspect the diffs. |
|
@danielfmiranda do you need me to do anything on this? I still can't review it. |
|
This PR introduces visual differences. Click here to inspect the diffs. |
Closes #7110
Before:
After:
Link to sample test page: https://foundation-s-7110-halve-bn8dnw.herokuapp.com/en/campaigns/regrets-reporter/findings/
Steps to test: