Snippet translations + translatable fields#6777
Snippet translations + translatable fields#6777KalobTaulien merged 42 commits intowagtail-localize-2021from
Conversation
* Removed modeltranslation * Django 3.1.11 and Wagtail 2.13 * Removed _en cases
|
Locally all the tests pass. @Pomax I pinged you for code review on this. |
b9a3842 to
f7371d6
Compare
Pomax
left a comment
There was a problem hiding this comment.
some minor notes, and a question
| objects = NewsQuerySet.as_manager() | ||
|
|
||
| class Meta: | ||
| class Meta(TranslatableMixin.Meta): |
There was a problem hiding this comment.
Let's check if this is actually necessary or not. If we don't need to mark the Meta class as translatable, that saves some migration work. (not much, but "not doing anything we don't need to do is worth not doing" =D)
network-api/networkapi/wagtailpages/pagemodels/dear_internet.py
Outdated
Show resolved
Hide resolved
network-api/networkapi/wagtailpages/pagemodels/publications/article.py
Outdated
Show resolved
Hide resolved
network-api/networkapi/wagtailpages/pagemodels/publications/publication.py
Outdated
Show resolved
Hide resolved
|
I’ve made a few changes to the spreadsheet (all highlighted in orange), mostly answering your questions. Also hit a few errors/have some questions: PNI General product:Translating a general product raises: Campaign pageTranslating a campaign page that has a petition + donate snippets raises: Youtube Regrets
Article pages:For Text and ID https://docs.google.com/spreadsheets/d/1AU7pxboZoBiVcbTpZO-VUMAhxZwx5mdEH_FBLfo2D-w/edit#gid=0&range=A43 these are fields I’ve found at the bottom of article pages, but I haven’t been able to find them in the model code HomepageHere too, a lot of the content is not localized, is this because these are blocks and it will come later? |
Co-authored-by: Pomax <pomax@nihongoresources.com>
Co-authored-by: Pomax <pomax@nihongoresources.com>
Co-authored-by: Pomax <pomax@nihongoresources.com>
Co-authored-by: Pomax <pomax@nihongoresources.com>
Co-authored-by: Pomax <pomax@nihongoresources.com>
Pomax
left a comment
There was a problem hiding this comment.
Let's get this landed and then deal with the followup as new work.
|
Ticket made for the campaign page problem. #6851 |



Closes #6708
Related PRs/issues #6703
Acceptance criteria
translatable_fields = [ .. ]set on themrequestobject, particularly around redirects.