Skip to content

Redirect /pt to /pt-BR#6263

Merged
TheoChevalier merged 2 commits intowagtail-localizefrom
new-issue-5993-pt-BR
Mar 1, 2021
Merged

Redirect /pt to /pt-BR#6263
TheoChevalier merged 2 commits intowagtail-localizefrom
new-issue-5993-pt-BR

Conversation

@mmmavis
Copy link
Collaborator

@mmmavis mmmavis commented Feb 26, 2021

Closes #5993

The old PR (#6193) was getting too hard to rebase and fix migrations so I created this new one to save the headache 😂 I basically copied all approved code changes from there plus one differnce in settings.py (see inline comment below). I'm not sure why but this PR no longer requires migration files to work. Is this the new wagtail-localize magic 😮 ?

Test urls:

@mofodevops mofodevops temporarily deployed to foundation-s-new-issue--0xkd43 February 26, 2021 05:49 Inactive
@mmmavis mmmavis changed the title Redirect /pt to /pt-BR (WIP) Redirect /pt to /pt-BR Feb 26, 2021
@mmmavis mmmavis temporarily deployed to foundation-s-new-issue--0xkd43 February 26, 2021 19:20 Inactive
@mmmavis mmmavis changed the title (WIP) Redirect /pt to /pt-BR Redirect /pt to /pt-BR Feb 26, 2021
Copy link
Contributor

@TheoChevalier TheoChevalier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmmavis, looking good!
And yes, I think it’s expected not to have migrations in this case with wagtail-localize

@TheoChevalier TheoChevalier merged commit eb7c74d into wagtail-localize Mar 1, 2021
@TheoChevalier TheoChevalier deleted the new-issue-5993-pt-BR branch March 1, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants