Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: New setting "closeByClickEvent" implemented #477

Closed
wants to merge 7 commits into from

Conversation

SeeeD
Copy link

@SeeeD SeeeD commented Aug 18, 2016

Hey @Mottie,

I created a bugfix for my commit.
If I am using the option "closeByClickEvent" and move from one to another input-field by click (I always tested one field or switching by tab) the input in the previous field gets lost.

This caused in reason of the special handling for a click. I fixed this and it should not have any impacts on other functions. :)

If you are interested I can show you a screenshot (by mail) showing how am I using the keyboard.

@SeeeD
Copy link
Author

SeeeD commented Aug 18, 2016

Well, I had some troubles syncing this branch with the master. Only the commit bb0c0bd is necessary, can you resolve this?

@Mottie
Copy link
Owner

Mottie commented Aug 19, 2016

Hi @SeeeD!

I'll take a look at this tomorrow.

…leared if the user click into the next input field
@Mottie Mottie closed this in 1c55c86 Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants