Use JQuery position() method instead of DOM .offset{Top|Left} #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eems to allow for table cells better.
|
I'm guessing you testing this to make sure it's working? If you accept being a collaborator, you can just merge this yourself 😉 Check out this crazy demo I was working on today to help a friend make the caret easier to position in an AnythingZoomer window. |
|
Yes, testing to check at least nothing obvious is broken. 😄 With luck, nothing at all will be. Happy to merge. If I do merge things like this, should I be updating any changelogs, or tagging releases or anything? Will continue submitting pull requests to give you a chance to comment on any changes before I merge. And yeah, that is one crazy demo! |
|
Naw, you don't have to update change logs, tag or push releases... unless you want to do that stuff LOL. This one looks good then, go for it. |
insightfuls
added a commit
that referenced
this pull request
Aug 18, 2015
Use JQuery position() method instead of DOM .offset{Top|Left} as it seems to allow for table cells better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to allow for table cells better.
Prior to this change, I found that putting an input in a table resulted in the caret not aligning.
Tested on a handful of desktop and tablet browsers and noticed no ill effects.