Error when hidding keyboard and using Navigation extension #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When hidding the keyboard a new call is made to checkKeys with an undefined key. That's the way to detect the keyboard is or has been hidden
|
I would merge this, but there isn't a guarantee that If you make that change, I'll merge it when I have some more internet time. |
Updated as requested by original coder Rob G
Mottie
added a commit
that referenced
this pull request
Oct 7, 2013
Error when hidding keyboard and using Navigation extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When keyboard is being hidden, a call to navigation extension checkKeys() method is made but with an undefined key. That's the way to detect base.$keyboard doesn't exist and return instead of throwing an exception