Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot return to input if usePreview: false and lockInput : true #77

Closed
jdaniells opened this issue Jun 15, 2012 · 4 comments
Closed

Cannot return to input if usePreview: false and lockInput : true #77

jdaniells opened this issue Jun 15, 2012 · 4 comments
Labels

Comments

@jdaniells
Copy link

If I have a keyboard with

usePreview: false
lockInput : true

once I have abandoned the input text, I cannot return to it.

I think the problem is that the attribute readonly is added to the input text and not removed after closing the keyboard.

I fixed it adding this lines:

if (o.lockInput && !o.usePreview) {
base.$el.removeAttr("readonly");
}

Inside the following block in base.close function:
if (!o.alwaysOpen) {
base.$keyboard.hide();
base.isVisible = false;
if (o.lockInput && !o.usePreview) {
base.$el.removeAttr("readonly");
}
}

@Mottie
Copy link
Owner

Mottie commented Jun 15, 2012

Hi jdaniells!

Thanks for reporting this issue and helping find the problem! I'll try to find time to look into this soon. :)

Mottie added a commit that referenced this issue Jun 17, 2012
@Mottie
Copy link
Owner

Mottie commented Jun 18, 2012

Hi jdaniells!

This should now be fixed in version 1.9.19! I appreciate the code fixes! :)

@Mottie
Copy link
Owner

Mottie commented Jul 2, 2012

I'm guessing this issue has been resolved, so I'm going to close it. Please feel free to reopen it if you continue to have problems. Thanks!

@Mottie Mottie closed this as completed Jul 2, 2012
@jdaniells
Copy link
Author

Hi Rob!

Yes it is fixed!

Thanks.

2012/7/2 Rob G <
[email protected]

I'm guessing this issue has been resolved, so I'm going to close it.
Please feel free to reopen it if you continue to have problems. Thanks!


Reply to this email directly or view it on GitHub:
#77 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants