Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key repeat can't be disabled #63

Closed
qc00 opened this issue Apr 20, 2012 · 6 comments
Closed

Key repeat can't be disabled #63

qc00 opened this issue Apr 20, 2012 · 6 comments

Comments

@qc00
Copy link

qc00 commented Apr 20, 2012

I was trying to debug my code using Firebug and the handlers are just called non-stop as the mouseup event was never received in the correct place.

I guess you should either check the position of the mouse when you do a repeat or make it possible to disable the repeat key feature.

(Setting the delay to a large value is not a viable option for me because I am writing a web-app and that long-delay timeout() could be seen as a memory leak.)

@Mottie
Copy link
Owner

Mottie commented Apr 24, 2012

I'll look into adding an option to disable the repeat in the next update and troubleshooting this problem. Thanks for reporting this issue!

Mottie added a commit that referenced this issue Apr 30, 2012
@Mottie
Copy link
Owner

Mottie commented Apr 30, 2012

I couldn't duplicate the issue you were having, but I added the ability to disable the repeat by setting the repeatRate to 0 (zero). I also added some scripting to clear the repeat, just in case.

Thanks again!

@qc00
Copy link
Author

qc00 commented Apr 30, 2012

Oh, sorry about that.
Procedures to reproduce:

  • Open firebug and set a break-point in the mouse-down event handler.
  • Click a button and move the cursor to press the continue button
  • Mouse-up never fired and the key repeats indefinitely.

@Mottie
Copy link
Owner

Mottie commented Apr 30, 2012

LOL, ok well can you reproduce it without using firebug? I tried to catch all of the scenarios, but I don't think I can stop someone from adding break-points.

@qc00
Copy link
Author

qc00 commented Apr 30, 2012

I guess this can't be reproduced unless something happened during the mouse-down event handler, which should be quite rare. But the ability to disable key-repeating is useful for many people I guess.

@Mottie
Copy link
Owner

Mottie commented Apr 30, 2012

Alrighty, I guess I'll just close this issue then. Thanks for the input!

@Mottie Mottie closed this as completed Apr 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants