add n4 correction script #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cakester
commented
Mar 26, 2021
requirements.txt
Outdated
| @@ -20,3 +20,4 @@ pytest-ordering | |||
| sphinx-jsonschema | |||
| pytest-console-scripts | |||
| pre-commit==2.10.1 | |||
| SimpleITK==2.1.0.dev211 | |||
There was a problem hiding this comment.
since SimpleITK/SimpleITK#1248 this issue, only the latest simpleitk from pre release works =/
cakester
force-pushed
the
hm/n4_correction
branch
from
4e29ee3 to
fe78891
Compare
cakester
force-pushed
the
hm/n4_correction
branch
from
fe78891 to
f904ca7
Compare
Pull Request Test Coverage Report for Build 697911514
💛 - Coveralls |
dyt811
reviewed
Mar 26, 2021
| @@ -20,5 +20,4 @@ pytest-ordering | |||
| sphinx-jsonschema | |||
| pytest-console-scripts | |||
| pre-commit==2.10.1 | |||
| --find-links https://github.com/SimpleITK/SimpleITK/releases/tag/latest | |||
| SimpleITK==2.1.0.dev211 | |||
| SimpleITK | |||
There was a problem hiding this comment.
Could you instead try:
SimpleITK --pre --find-links https://github.com/SimpleITK/SimpleITK/releases/tag/latest?
|
we were forced to use the prerelease branch of simpleitk because of this commit SimpleITK/SimpleITK@c7f759f, its not a good idea to use prerelase version of libraries, so reverting the n4_correction script to a version older than that commit, which would fix ci as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
GitHub
PR contents
Description
Linked issues
ivadomed#3