add sha256 for training data #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 698341617
💛 - Coveralls |
dyt811
reviewed
Mar 29, 2021
ivadomed/main.py
Outdated
| # generating sha256 for training data | ||
| context['training_sha256'] = {} | ||
| for file in train_lst: | ||
| df_sub = bids_df.df.loc[bids_df.df['filename'] == file] |
There was a problem hiding this comment.
Could you add a bit comment about this line in particular?
dyt811
requested changes
Mar 29, 2021
There was a problem hiding this comment.
Good stuff. I think more clarity will always help future developers or even you who look at this code down the road. Unit test is a mandatory requirement for IvadoMed. Be wary of its very convoluted pathing issue... which may cause problems. bigger than the SHA2 issue you are trying to fix. Test thoroughly.
ivadomed/main.py
Outdated
Comment on lines
351
to
354
| sha256_hash = hashlib.sha256() | ||
| with open(file_path, "rb") as f: | ||
| for byte_block in iter(lambda: f.read(4096), b""): | ||
| sha256_hash.update(byte_block) |
There was a problem hiding this comment.
Could you add a unit test for this portion and externalize this portion as a dedicated block hashing function?
ivadomed/main.py
Outdated
| @@ -342,6 +343,17 @@ def run_command(context, n_gif=0, thr_increment=None, resume_training=False): | |||
| context["loader_parameters"] | |||
| ['subject_selection']) | |||
|
|
|||
| # generating sha256 for training data | |||
| context['training_sha256'] = {} | |||
| for file in train_lst: | |||
There was a problem hiding this comment.
could you add comment clarifying what is in the file, is it a string representing file name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
GitHub
PR contents
Description
Linked issues
ivadomed#9