Additions to have dispute tokens #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, the buyer and seller must know their dispute token when the dispute is opened, so that in case an admin impersonator writes to them, they ask for the token and they know that it is a scammer because they will not be able to give it to them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @grunch , @Catrya
added some data in structs
SmallOrderand inPeerenum to have the dispute tokens.Simply a quick implementation, maybe we can do it better. Looking here seems that tokens are not saved on a db, so I did a quick generation of random number in the u16 range and sent the message to buyer, seller and admin who takes dispute. Messages are sent when admin takes the dispute, don't know if this is the desired behaviour and maybe we need to send messages when dispute is opened.
Let me know.
Did not test now because I will be AFK til the evening now.