You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When running the test suite with MSVC in Debug mode, some grail_sorter tests failed because of the creation of out-of-bounds iterators.
353 - every random-access sorter with stable_adapter - cppsort::grail_sorter<> (Failed)
407 - test random-access sorters with all_equal distribution - cppsort::grail_sorter<> (Failed)
408 - test random-access sorters with all_equal distribution - cppsort::grail_sorter< cppsort::utility::dynamic_buffer<cppsort::utility::sqrt> > (Failed)
445 - test sorter with alternating_16_values distribution - cppsort::grail_sorter<> (Failed)
446 - test sorter with alternating_16_values distribution - cppsort::grail_sorter< cppsort::utility::dynamic_buffer<cppsort::utility::sqrt> > (Failed)
651 - test sorter with shuffled_16_values distribution - cppsort::grail_sorter<> (Failed)
652 - test sorter with shuffled_16_values distribution - cppsort::grail_sorter< cppsort::utility::dynamic_buffer<cppsort::utility::sqrt> > (Failed)
There is a clear pattern here: grail_sorter fails when there are lots of equivalent elements, which means that the culprit is likely in strategy 2 and/or strategy 3.
The text was updated successfully, but these errors were encountered:
Grailsort creates invalid pointers here and there that are never
dereferenced, so generally don't cause any issues. However, forming
invalid iterators like that might cause issues, and MSVC debug iterators
do trip on grailsort.
This commit only fixes "strategy 3": when the algorithm can't find at
least 4 unique keys in the collection.
Grailsort creates invalid pointers here and there that are never
dereferenced, so generally don't cause any issues. However, forming
invalid iterators like that might cause issues, and MSVC debug iterators
do trip on grailsort.
This commit only fixes "strategy 3": when the algorithm can't find at
least 4 unique keys in the collection.
When running the test suite with MSVC in Debug mode, some
grail_sorter
tests failed because of the creation of out-of-bounds iterators.There is a clear pattern here:
grail_sorter
fails when there are lots of equivalent elements, which means that the culprit is likely in strategy 2 and/or strategy 3.The text was updated successfully, but these errors were encountered: