[Frontend] Fixes a bug with the QR code modal being able to be toggled via the connect wallet button #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glhuang
changed the title
glhuang
changed the title
Adding traffic lights (close, minimize, maximize buttons) for better UI
[UI/UX Fix] Show network dropdown if the wallet is connected
adding rag vectorstores
|
@glhuang please commit this into the current development branch. |
Done! |
Added traffic lights- UI improvement
Update build.yml
Warning: ReactDOM.render is no longer supported fix
changed to yarn
Node upgrade to 20
|
@glhuang please see the failed builds. |
|
Hi, build is failing because of the node version upgrade in file .github/workflows/build.yml The bug mentioned in this PR is already resolved in development branch. @glhuang @betterbrand |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug I noticed where exiting out of the
QrCodeModalwhen clicking theconnectbutton doesn't allow for it to be reshown on subsequentconnectbutton clicks. (See before vs after).Early return for the
modalContainerDOM element shouldn't be necessary since atunmountwe ensure that themodalContainerelement is removed.Before
Screen.Recording.2024-03-01.at.5.57.23.PM.mov
After
Screen.Recording.2024-03-01.at.5.56.24.PM.mov